Skip to content

Conversation

madpah
Copy link
Collaborator

@madpah madpah commented Jan 27, 2022

* WIP but a lil hand up for @madpah

Signed-off-by: Jeffry Hesse <[email protected]>

* chore: added missing license header

Signed-off-by: Paul Horton <[email protected]>

* No default values for required fields

* Add Services to BOM

* Typo fix

* aligned classes with standards, commented out Signature work for now, added first tests for Services

Signed-off-by: Paul Horton <[email protected]>

* addressed standards

Signed-off-by: Paul Horton <[email protected]>

* 1.2.0

Automatically generated by python-semantic-release

Signed-off-by: Paul Horton <[email protected]>

* feat: `bom-ref` for Component and Vulnerability default to a UUID (#142)

* feat: `bom-ref` for Component and Vulnerability default to a UUID if not supplied ensuring they have a unique value #141

Signed-off-by: Paul Horton <[email protected]>

* doc: updated documentation to reflect change

Signed-off-by: Paul Horton <[email protected]>

* patched other tests to support UUID for bom-ref

Signed-off-by: Paul Horton <[email protected]>

* better syntax

Signed-off-by: Paul Horton <[email protected]>

* 1.3.0

Automatically generated by python-semantic-release

Signed-off-by: Paul Horton <[email protected]>

* WIP but a lil hand up for @madpah

Signed-off-by: Jeffry Hesse <[email protected]>
Signed-off-by: Paul Horton <[email protected]>

* chore: added missing license header

Signed-off-by: Paul Horton <[email protected]>

* aligned classes with standards, commented out Signature work for now, added first tests for Services

Signed-off-by: Paul Horton <[email protected]>

* removed signature from this branch

Signed-off-by: Paul Horton <[email protected]>

* Add Services to BOM

* Typo fix

* addressed standards

Signed-off-by: Paul Horton <[email protected]>

* resolved typing issues from merge

Signed-off-by: Paul Horton <[email protected]>

* added a bunch more tests for JSON output

Signed-off-by: Paul Horton <[email protected]>

Co-authored-by: Paul Horton <[email protected]>
Co-authored-by: github-actions <[email protected]>
@madpah madpah requested a review from a team as a code owner January 27, 2022 09:45
@madpah madpah added the enhancement New feature or request label Jan 27, 2022
@madpah madpah added this to the 1.1.0 milestone Jan 27, 2022
@jkowalleck
Copy link
Member

@madpah let me know if you need a second opinion or a code review

feat: support nested services in JSON and XML BOMs

Signed-off-by: Paul Horton <[email protected]>
* fix: implemented correct `__hash__` methods in models (#153)

Signed-off-by: Paul Horton <[email protected]>
@madpah madpah changed the title NEXT FEATURE RELEASE RELEASE 2.0.0 Feb 3, 2022
@jkowalleck jkowalleck self-requested a review February 3, 2022 19:53
* BREAKING CHANGE: update models to use `Set` and `Iterable` rather than `List[..]`
BREAKING CHANGE: update final models to use `@property`
wip

Signed-off-by: Paul Horton <[email protected]>
* feat: support complete model for `bom.metadata`
fix: JSON comparison in unit tests was broken
chore: corrected some source license headers

Signed-off-by: Paul Horton <[email protected]>
@madpah madpah dismissed jkowalleck’s stale review February 8, 2022 14:06

All resolved, but review not closing?

…(in the schema it is) - we generate a UUID if `bom_ref` is not supplied explicitly

Signed-off-by: Paul Horton <[email protected]>
fix: resolved #169 (part of #155)
feat: as part of solving #155, #147 has been implemented

Signed-off-by: Paul Horton <[email protected]>
…sure uniquness and dependency references (#174)

Signed-off-by: Paul Horton <[email protected]>
…175)

* BREAKING CHANGE: added new model `BomRef` unlocking logic later to ensure uniquness and dependency references

Signed-off-by: Paul Horton <[email protected]>

* updated Vulnerability to also use new `BomRef` model

Signed-off-by: Paul Horton <[email protected]>
@madpah madpah dismissed jkowalleck’s stale review February 21, 2022 13:13

All points actioned.

BREAKING CHANGE: Adopt PEP-3102

BREAKING CHANGE: Optional Lists are now non-optional Sets

BREAKING CHANGE: Remove concept of DEFAULT schema version - replaced with LATEST schema version

BREAKING CHANGE: Added `BomRef` data type

Signed-off-by: Paul Horton <[email protected]>
@madpah madpah merged commit 631e400 into main Feb 21, 2022
@madpah madpah deleted the feat/add-bom-services branch March 30, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment